Submitting code to OpenSim/de

From OpenSimulator

Revision as of 06:12, 14 July 2015 by Chris Weymann (Talk | contribs)

Jump to: navigation, search

  • Nicht alle patches schaffen es in OpenSimulator.
  • Zugunsten der Code Komplexität sollten alle Funktionen, die nicht grundlegend für den betrieb notwenig sind, in externe Module ausgelagert werden. Wenn du dafür extra Schnittstellen oder Events brauchst fühle dich frei welche anzulegen.
  • Du kannst Code in form von Patch Files über das Mantis System einreichen.
    Ein weg solche zu erstellen ist über den git Befehl:
git format-patch <commit hash>^!

Dies wird alle deine Änderungen in eine einzelne Datei verpacken.

  • Please run the automated tests (via "nant test" on the command line) before submitting your patch. Patches that add new tests (either to test accompanying patch code or to test existing code) are very welcome.
  • Please put only one logical change in a patch at a time. Patches that contain more than one logical change tend to be larger, more complex and hence take more time to be applied. At worse, developers will tend not to look at them because it's hard to disentangle all the possible effects.
  • In your Mantis, the title line should ideally start with [PATCH]. When you've opened it, change the state to patch included. Once you've put in on a Mantis, you may want to hop on the IRC channels and mention it someone there (though at the moment we're pretty good at getting round to these, since e-mails about newly opened mantis entries are sent to developers automatically).
  • Once you've submitted your patch please move the Mantis entry into the Patch Included state to let us know there's a patch waiting to be reviewed. It might take a bit longer to see a mantis entry with a patch if it's not in this state (and in unfortunate rare cases it may be missed altogether for a period).
  • General turnaround time for patch review is a week. though, it could be up to two weeks depending on the situation. If you want to chat about a patch (or remind people that it exists after a week has gone by), please feel free to pop into #opensim-dev on IRC or send an e-mail to the opensim-dev ailing list.
  • When a patch is reviewed, it will either be applied (in which case, thanks very much!) or the Mantis entry will be changed to the "Patch feedback" state with comments from developers/interested parties. If you revise the patch in light of the discussion, please then change the state back to "Patch Included".
  • If you're looking for an initial piece of code to do, the bugs in Mantis are a very good starting point. You may want to see if there's anybody on IRC to discuss the difficulty of a particular bug (they do vary, sometimes in unexpected ways).
Personal tools
About This Wiki